[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Client-side support for Cyrus SASL

From: D.J. Heap <djheap_at_gmail.com>
Date: 2006-07-03 04:53:55 CEST

On 6/16/06, Vlad Georgescu <vgeorgescu@gmail.com> wrote:
[snip]
> [[[
> Implement support for Cyrus SASL on the client side.
>
> * configure.in
> Define SVN_HAVE_SASL
>
> * subversion/libsvn_ra_svn/sasl_auth.c: New file.
>
> * subversion/libsvn_ra_svn/trivial_auth.c: New file. Contains
> functions taken from client.c.
>
> * subversion/libsvn_ra_svn/client.c
> (ra_svn_session_baton_t): Moved to ra_svn.h and renamed to
> svn_ra_svn__session_baton_t. Changed all occurances to reflect this.
> (find_mech, read_success): Moved to trivial_auth.c.
> (do_auth): Moved to trivial_auth.c and renamed to svn_ra_svn__handle_auth.
> (auth_response): Renamed to svn_ra_svn__auth_response.
> (svn_ra_svn__init): Call svn_ra_svn__sasl_init.
> (open_session): Call svn_ra_svn__sasl_new.
> Updated comments to reflect changes.
>
> * subversion/libsvn_ra_svn/ra_svn.h
> Conditionally #include <sasl/sasl.h>
> (svn_ra_svn_conn_st): Add new member: sasl_conn.
> (svn_ra_svn__handle_auth,
> svn_ra_svn__auth_response,
> svn_ra_svn__sasl_init,
> svn_ra_svn__sasl_new): New declarations.
> ]]]

I've updated the Windows build generator to optionally include sasl
support and have successfully tested a bit with this patch (after a
couple of tweaks). Here's the Win32 build patch in case anyone else
wants to test sasl support on Win32.

Does anyone know if and how to make the sasl libraries
runtime-relocatable or does it only support build-time relocation for
the binaries? It is pretty weird/unfriendly to require specific and
absolute paths on Windows. I traced through the code and tried
looking at build options a bit, but didn't find anything obvious...

DJ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Mon Jul 3 04:54:26 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.