[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r20300 - trunk/subversion/tests/cmdline/svntest

From: Madan U Sreenivasan <madan_at_collab.net>
Date: 2006-06-30 11:36:26 CEST

On Fri, 30 Jun 2006 04:55:50 +0530, <dlr@tigris.org> wrote:

> Author: dlr
> Date: Thu Jun 29 16:25:50 2006
> New Revision: 20300
>
> Modified:
[snip]

> - # If you already have the node,
> else:
> + for a in self.children:
> + if a.name == newchild.name:
> + child_already_exists = 1
> + break
> +
> + if child_already_exists:
> if newchild.children is None:
> # this is the 'end' of the chain, so copy any content here.
> a.contents = newchild.contents
> @@ -180,6 +177,9 @@
> # try to add dangling children to your matching node
> for i in newchild.children:
> a.add_child(i)
> + else:
> + self.children.append(newchild)
> + newchild.path = os.path.join(self.path, newchild.name)

    This has changed the logic of the existing code. Now the function
doesnt do add_child() of the newchild's children. Am wondering why you
made this change.

Regards,
Madan.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 30 11:06:19 2006

This is an archived mail posted to the Subversion Dev mailing list.