[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Proof-of-concept patch for APR 1.2 support on Windows

From: Sergey A. Lipnevich <sergey_at_optimaltec.com>
Date: 2006-06-28 13:55:36 CEST

Branko Čibej wrote:
> Sergey A. Lipnevich wrote:
>
>> ...
>> mentioned in these threads, and came up with the following patch
>> (borrowing an idea from D.J. Heap's patch above for
>> svn_io_set_file_read_write_carefully). It's not intended for commit as
>> it is. Please let me know if this is the right approach to take, and
>> what needs to be done to finish this patch.
>>
>>
> The thing to do is to propose djh's patch for backport to the 1.3.x
> line. We never make unrelated changes on the release branches, we always
> port fixes from trunk.
>
Thanks! I'll redo it against trunk then. I was hoping to get a cursory
review first as my patch does more than just eliminate
svn_io_set_file_read_write_carefully, as described in the log message.
Among other things, it uses one internal APR constant (APR_FREADONLY),
which I am not sure is going to be liked :-).
Best,

Sergey.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jun 28 13:57:47 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.