Re: crash with incomplete url
From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2006-06-25 03:40:57 CEST
Stefan Küng wrote:
This thread turned to the question of what the policy should be, and died out.
1.
> SVN_ERR(parse_url(url, &uri, sess_pool));
parse_url() can set uri.hostinfo to null (e.g. on url="svn+ssh://").
> SVN_ERR(find_tunnel_agent(tunnel, uri.hostinfo, &tunnel_argv, config,
find_tunnel_agent() is not documented as accepting null, and crashes. In fact
2.
> * Note that the contents of @a base are not examined, so it is possible to
However, the implementation doesn't handle URLs very well. It starts off with:
> assert(is_canonical(base, blen));
but is_canonical() fails on some things that svn_path_canonicalize() returns,
With that fixed, svn_path_join() wouldn't crash, but I'm not convinced its
These two are definite bugs and seem to have straightforward fixes. Anyone
Tests would also be very welcome. They probably need to call the APIs directly
- Julian
---------------------------------------------------------------------
|
This is an archived mail posted to the Subversion Dev mailing list.
This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.