[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Return error code rather than crash in svn_wc_crawl_revisions2()

From: Madan U Sreenivasan <madan_at_collab.net>
Date: 2006-06-23 23:09:56 CEST

On Fri, 23 Jun 2006 17:00:43 +0530, Jelmer Vernooij <jelmer@samba.org>
wrote:

> Hi,
>
> [[[
> Return error code for unversioned files in svn_wc_crawl_revisions2()
> rather than crashing.
>
> * subversion/libsvn_wc/adm_crawler.c
> (svn_wc_crawl_revisions2): Return error for unversioned files.
> ]]]

Am wondering how we dodge the following check:

   if ((! entry) || ((entry->schedule == svn_wc_schedule_add)
                     && (entry->kind == svn_node_dir)))

for an unversioned path?

yeah, like Garrett said, could you pl. give us a recipe pl. (If you write
a cmdline/python binding test case, we could reuse it to check it in along
with the fix - just a suggestion :)

Regards,
Madan U S
www.symonds.net/~madan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 23 17:40:53 2006

This is an archived mail posted to the Subversion Dev mailing list.