[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Return error code rather than crash in svn_wc_crawl_revisions2()

From: Jelmer Vernooij <jelmer_at_samba.org>
Date: 2006-06-23 17:01:21 CEST

On Fri, 2006-06-23 at 16:55 +0200, Jelmer Vernooij wrote:
> On Fri, 2006-06-23 at 10:47 -0400, Garrett Rooney wrote:
> > On 6/23/06, Jelmer Vernooij <jelmer@samba.org> wrote:
> > > Hi,
> > >
> > > [[[
> > > Return error code for unversioned files in svn_wc_crawl_revisions2()
> > > rather than crashing.
> > >
> > > * subversion/libsvn_wc/adm_crawler.c
> > > (svn_wc_crawl_revisions2): Return error for unversioned files.
> > > ]]]
> >
> > Do you have a way to reproduce this problem? I'm just curious how it
> > can actually happen...
> Yep, just pass an unversioned path to svn_wc_crawl_revisions2().
>
> This was biting us in the Python bindings.
To be more specific: This problem occurs because svn_wc_entry() returns
a successful error code at subversion/libsvn_wc/adm_crawler.c:449 but
parent_entry is set to NULL (indicating a unversioned file according to
svn_wc.h).

Other places in the code (such as svn_wc_merge_props) explicitly check
for this already.

Cheers,

Jelmer

-- 
Jelmer Vernooij <jelmer_at_samba.org> - http://samba.org/~jelmer/

Received on Fri Jun 23 17:03:00 2006

This is an archived mail posted to the Subversion Dev mailing list.