[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix Python bindings to svn.wc.crawl_revisions2()

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-06-23 16:55:23 CEST

On 6/23/06, Jelmer Vernooij <jelmer@samba.org> wrote:
> Hi,
>
> [[[
> Fix Python bindings to svn.wc.crawl_revisions2().
>
> [in subversion/bindings/swig]
>
> * svn_ra.i: Add Python typemap for svn_ra_reporter2_t.
>
> * svn_wc.i: Add Python typemap for svn_wc_notify_func2_t.
>
> * tests/wc.py
> (setUp): Open working copy subdirectories.
> (test_crawl_revisions2): Add test for svn.wc.crawl_revisions2() and
> svn_ra_reporter2_t implementations.
>
> * python/libsvn_swig_py/swigutil_py.c
> (make_ob_wc_notify): Add function.
> (svn_swig_py_notify_func2): Add Python wrapper for
> svn_wc_notify_func2_t.
> (reporter_set_path): Add function.
> (reporter_delete_path): Add function.
> (reporter_link_path): Add function.
> (reporter_abort_report): Add function.
> (reporter_finish_report): Add function.
> (swig_py_ra_reporter2): Add Python wrapper for svn_ra_reporter2_t.
>
> * python/libsvn_swig_py/swigutil_py.h
> (swig_py_ra_reporter2): Add extern.
> (svn_swig_py_notify_func2): Add prototype.
> ]]]

I'm totally unqualified to evaluate this patch, but I do notice that
it's full of tabs, and appears to have been written assuming that tab
== 4 spaces, which totally screws up the indenting in 'svn diff'
output, that'll have to be fixed before it can be applied.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 23 16:56:23 2006

This is an archived mail posted to the Subversion Dev mailing list.