[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add some RDoc comments to the SWIG/Ruby bindings, part 1

From: Kouhei Sutou <kou_at_cozmixng.org>
Date: 2006-06-23 03:43:43 CEST

Hi,

2006/6/23, Kobayashi Noritada <nori1@dolphin.c.u-tokyo.ac.jp>:

> > > + # Following methods are also available:
> > > + #
> > > + # [path]
> > > + # Returns a path concerned with the instance.
> > > + # [prop_changed]
> > > + # Returns +true+ when the instance is a change involving a property
> > > + # change.
> > > + # [prop_changed?]
> > > + # Ditto.
> > > class DiffSummarize
> > > alias prop_changed? prop_changed
> >
> > I don't want users to see prop_changed? alias.
>
> I think it is odd and wonder it goes against what you intend to do.
> The alias 'prop_changed?' is defined so as for users to use the Rubyish
> method name, isn't it? Inversely, users aren't expected to use the original
> method name, 'prop_changed', I think.

Yes, you're right. It is my mistake.

Could you please commit the patch, nori?
I have a request after you commit. Please see below...

Thanks,

--
kou
> +    # Following methods are also available:
> +    #
> +    # [created_rev]
> +    #   Returns a revision at which the instance was last modified.
> +    # [has_props]
> +    #   Returns true if the instance has properties.
> +    # [last_author]
> +    #   Returns an author who last modified the instance.
> +    # [size]
> +    #   Returns a size of the instance.
>      class Dirent
We should provide have_props? method instead of has_props to make
the bindings more Rubyish. Could you add a new alias and update
the corresponded commet after you commit?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 23 03:44:19 2006

This is an archived mail posted to the Subversion Dev mailing list.