[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Correct svn_wc_get_pristine_copy_path() comment.

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2006-06-22 22:48:27 CEST

Madan U Sreenivasan wrote:
> For the comment I would suggest,
>
> /* Given any @a path, return where svn would look for its BASE version. */
>
> No mention of whether the path exists/if the text-base dir exists/
> if the file has a text-base file/if it is a WC file/if it is a file or
> a dir - nothing. I think it conveys what exactly the function does. The
> function simply doesn't care about these factors.

That's OK with me. (The comment should say "Set @a pristine_path to ..."
rather than "return".)

> Another point I would like to discuss is:
> svn_wc_get_pristine_copy_path() doesn't even care if the path given is
> a file or a dir.
>
> --------------------8<----------------------------------------------8<--------------------------
>>>> svn.wc.get_pristine_copy_path("/tmp")
>
> '/.svn/text-base/tmp.svn-base'
> --------------------8<----------------------------------------------8<--------------------------
>
> Is this intentional? AFAIK, the wc dirs do not have a text-base file.
> Shouldn't this case return an error?

Either the function should validate that the path is a real WC path of a file
that has a text-base, or it should not care about any such things including
whether it is a file or a directory. I don't think this distinction between
file and dir is any more or less important than the other factors that you
mentioned above.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 22 22:48:52 2006

This is an archived mail posted to the Subversion Dev mailing list.