[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Agggh! 64-bit bug still present in 1.3.2 [PATCH]

From: David Summers <david_at_summersoft.fay.ar.us>
Date: 2006-06-22 15:53:24 CEST

OK, that patch fails when I applied it to a 32-bit system so we need
an %ifarch statement there. If you could do that and try it out and if it
works send that patch or tonight I can try to do that and send it to you
and then you could try it out and let me know. Either way is fine. If I
don't hear from you then I'll try to generate that tonight and send it
out.

    Thanks.
    - David

On Wed, 21 Jun 2006, Toby Johnson wrote:

> Date: Wed, 21 Jun 2006 00:54:48 -0400
> From: Toby Johnson <toby@etjohnson.us>
> To: David Summers <david@summersoft.fay.ar.us>
> Cc: Nico Kadel-Garcia <nkadel@comcast.net>, dev <dev@subversion.tigris.org>
> Subject: Re: Agggh! 64-bit bug still present in 1.3.2 [PATCH]
>
> David Summers wrote:
>>
>> On Mon, 5 Jun 2006, Toby Johnson wrote:
>>
>>> Nico Kadel-Garcia wrote:
>>>> My latest patch is at:
>>>>
>>>> http://subversion.tigris.org/nonav/issues/showattachment.cgi/558/x86_64.patch
>>>
>>>
>>> Nico, as long as we're replacing hardcoded paths with built-in rpmbuild
>>> macros, shouldn't the following substitutions also be made?
>>>
>>> /usr/bin => %{_bindir}
>>> /usr/include => %{_includedir}
>>> /usr/share/man => %{_mandir}
>>> /usr/share => %{_datadir}
>>>
>>
>> If someone could try the latest trunk and see if my /usr/bin -> %{_bindir}
>> and /usr/lib -> %{_libdir} has helped 64-bit users at all and let me know,
>> it would be appreciated.
>>
>> I still don't have a 64-bit system but I will soon order one (yay, more
>> toys) so hopefully soon I'll be able to verify this stuff.
>>
>> Until then, I either need feedback from someone else or if someone could
>> offer a login on a 64-bit system for a while that would be appreciated.
>>
>> If we can get a clean 64-bit RPM build on trunk then we can back-port to
>> 1.4.x and/or 1.3.x.
>>
>
> Hello David, I finished running without checks enabled on 64-bit CentOS-4 and
> hit a couple snags, which the attached patch corrects (just a couple more
> missed /usr/lib64 locations). I'm assuming the patch can/should be applied
> for the other distros as well but I currently have no means of testing those.
>
> The Makefile for building the RPMs still doesn't work, due to the hardcoded
> 32-bit paths in there, but I'm not really worried about that... it makes it
> up to and including creation of the RPMs anyway.
>
> I'll run again with full tests and let you know if I find anything else.
>
> toby
>

-- 
David Wayne Summers        "Linux: Because reboots are for hardware upgrades!"
david_at_summersoft.fay.ar.us PGP Key: http://summersoft.fay.ar.us/~david/pgp.txt
PGP Key fingerprint =  0B44 B118 85CC F4EC 7021  1ED4 1516 5B78 E320 2001
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 22 16:10:58 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.