Re: [PATCH] Add some RDoc comments to the SWIG/Ruby bindings, part 1

Hi,

In <20060622.180233.07615330.nori1@dolphin.c.u-tokyo.ac.jp>
  "Re: [PATCH] Add some RDoc comments to the SWIG/Ruby bindings, part 1" on Thu, 22 Jun 2006 18:02:33 +0900 (JST),
  Kobayashi Noritada <nori1@dolphin.c.u-tokyo.ac.jp> wrote:

> Sorry for taking some days to respond...
> # And sorry for sending the previous patch included inline, not as an
> # attachment.

No problem. :)

> > There are some comments in your patch.
>
> Thank you for giving comments. I've fixed and here attach a new patch.

I also have some comments. I'm sorry that I missed them last
time...

Thanks,

--
kou
> Index: subversion/bindings/swig/ruby/svn/client.rb
>      PropListItem = ProplistItem
> +    # Following methods are also available:
> +    #
> +    # [name]
> +    #   Returns an URI for the item concerned with the instance.
> +    # [node_name]
> +    #   Ditto.
> +    # [prop_hash]
> +    #   Returns a Hash of properties, such as
> +    #   <tt>{propname1 => propval1, propname2 => propval2, ...}</tt>.
> +    # [props]
> +    #   Ditto.
>      class PropListItem
>        alias name node_name
>        alias props prop_hash
I think node_name and prop_hash aren't Rubyish name. So I
aliased to name and props. I don't want users to see
node_name and prop_hash. Could you remove them?
> +    # Following methods are also available:
> +    #
> +    # [path]
> +    #   Returns a path concerned with the instance.
> +    # [prop_changed]
> +    #   Returns +true+ when the instance is a change involving a property
> +    #   change.
> +    # [prop_changed?]
> +    #   Ditto.
>      class DiffSummarize
>        alias prop_changed? prop_changed
I don't want users to see prop_changed? alias.
>        def kind_normal?
> +      # Returns +true+ when the instance is a normal change.
Those lines should be transposed.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org