Re: [PATCH] Regexp support for svn:ignore

On 6/17/06, Osku Salerma <osku@iki.fi> wrote:

> The patch is more or less a proof-of-concept, with at least the following
> issues to be decided/solved before it can be finished:
>
> * Do we even want to add a new dependency for a regexp library?

I'm not overly thrilled with this honestly...

> * If so, which one? My patch uses PCRE (www.pcre.org), which seems to be
> the most popular one, e.g. Apache uses it.

Well, if we're going to use a regex library, PCRE is probably the one
to go with.

> * If we use PCRE, how do we handle
> http://issues.apache.org/bugzilla/show_bug.cgi?id=27550 ? Apache bundles
> its own version of PCRE, and if an Apache module links to an external
> PCRE, there are problems. I assume mod_dav_svn would be affected by
> this. The bug report claims it's fixed in Apache 2.1, but I suppose we
> must support Apache 2.0.

Yeah, that would be an issue to work around. Maybe if we're building
mod_dav_svn we use Apache's version of PCRE?

> * My patch adds the PCRE library globally to all executables, even though
> only libsvn_wc (currently) needs it. Do we want to make it a global
> dependency or not?

I'd prefer to limit it, if we have to have it at all.

> * Windows buildsystem needs to be modified.
>
> * Error handling. The attached patch dies on errors (invalid regexp,
> invalid UTF-8, etc). Do we want to silently ignore errors, modify
> svn_wc_match_ignore_list to return possible errors, or what?

Maybe evaluate them at parse time to see if they're invalid?

> * Do we need to test that PCRE was compiled with UTF-8 support enabled? If
> so, at configure time, at run-time, or both?

Another good question...

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 19 18:18:13 2006