[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Correct svn_wc_get_pristine_copy_path() comment.

From: Madan U Sreenivasan <madan_at_collab.net>
Date: 2006-06-19 15:00:32 CEST

Hi,

    Recently, I encountered a problem while writing python bindings tests.

    The comment for svn_wc_get_pristine_copy_path() API currently says that
the function will return a NULL value for the pristine_path parameter when
the text-base does not exist. However, this is not so.

    I spoke with eh on irc sometime back, and eh felt that this API might
be used in places where the text-base does not exist, but has to be
created. For example in case of a cp/mv. So, we felt the right thing was
to fix the comment.

    Pl. find herewith the patch and log.

[[[
Correct comment for svn_wc_get_pristine_copy_path().

* subversion/include/svn_wc.h
   (svn_wc_get_pristine_copy_path): svn_wc_get_pristine_copy_path() doesnt
    return NULL for the pristine_path parameter, if passed a wc path, for
    which a text-base doesn't exist. Removed part of the comment that says
so.
]]]

Regards,
Madan.

Index: subversion/include/svn_wc.h
===================================================================
--- subversion/include/svn_wc.h (revision 20165)
+++ subversion/include/svn_wc.h (working copy)
@@ -3034,9 +3034,7 @@
 
 
 /** Given a @a path to a wc file, return a @a pristine_path which points to a
- * pristine version of the file. This is needed so clients can do
- * diffs. If the WC has no text-base, return a @c NULL instead of a
- * path.
+ * pristine version of the file. This is needed so clients can do diffs.
  */
 svn_error_t *svn_wc_get_pristine_copy_path(const char *path,
                                            const char **pristine_path,

Correct comment for svn_wc_get_pristine_copy_path().

* subversion/include/svn_wc.h
  (svn_wc_get_pristine_copy_path): svn_wc_get_pristine_copy_path() doesnt
   return NULL for the pristine_path parameter, if passed a wc path, for
   which a text-base doesn't exist. Removed part of the comment that says so.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 19 14:35:34 2006

This is an archived mail posted to the Subversion Dev mailing list.