[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH][1.4.x!] Fix slew of blame issues

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2006-06-18 19:11:14 CEST

Erik Huelsmann wrote:
> [[[
> Fix slew of blame issues:
>
> - Make blame output 'client output' instead of 'raw output'

I know what you mean by that phrase but only because I read your earlier messages.

> - Eliminate blame-slowdown wrt 1.3.x (by eliminating
> translation of intermediate files)
> - Make 'line' argument of svn_client_blame_receiver_t better defined
> - Stop passing CR characters in the 'line' argument of
> svn_client_blame_receiver_t
> - Fix blame of CR-eol style file
> -

Eric, it's great that you've got fixes for all these issues, but this contains
unrelated changes in one patch. We might want to port some of them (and not
others) to a release branch, for example.

It looks to me like there are two changes here:

1. Fix a slow-down (a performance regression)

2. Fix line-ending handling (including fixes for specific bugs and the semantic
decision to use platform-specific line endings rather than what was in the file)

It would be great if you could separate them.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Jun 18 19:11:24 2006

This is an archived mail posted to the Subversion Dev mailing list.