On Sun, 2006-06-18 at 01:25 -0700, David James wrote:
> On 6/17/06, Jelmer Vernooij <firstname.lastname@example.org> wrote:
> 2) In svn_swig_py_ra_file_rev_handler_func, we should pass in
> py_prop_diffs to the callback function instead of the regular
> "prop_diffs". (prop_diffs is not a Python object.)
Well spotted, thanks.
> Once these issues are fixed, this is ready to commit, I think.
Fixed version is attached. Is this ok to commit?
Fix Python bindings for svn.ra.get_file_revs().
(svn_swig_py_ra_file_rev_handler_func): Add Python wrapper for
(svn_swig_py_proparray_to_dict): New function.
* subversion/bindings/swig/svn_ra.i: Add typemap for
(test_get_file_revs): Add test for svn.ra.get_file_revs().
Since Python has the ability to store entries with value None in
dictionaries that are different from nonexisting entries (unlike
apr_hash_t) I chose to use a dictionary rather than a list of
(name,value) tuples for prop_diffs.
Jelmer Vernooij <jelmer_at_samba.org> - http://samba.org/~jelmer/
Received on Sun Jun 18 17:20:05 2006