[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Normalize svn:ignore pattern matching

From: Ivan Zhakov <chemodax_at_gmail.com>
Date: 2006-06-17 11:16:13 CEST

On 6/17/06, Osku Salerma <osku@iki.fi> wrote:
> On Sat, 17 Jun 2006, Ivan Zhakov wrote:
>
> > On 6/16/06, Osku Salerma <osku@iki.fi> wrote:
> > > Currently, knowledge that svn:ignore only supports glob patterns is
> > > duplicated in four functions: send_unversioned_item, add_dir_recursive,
> > > import_dir, and import. This is bad for modularity, as you would need to
> > > modify all four places if you e.g. added support for reg-exps in
> > > svn:ignore patterns.
> > >
> > > The attached patch modifies the four functions to use a new function,
> > > svn_cstring_match_ignore_list, that currently only forwards to
> > > svn_cstring_match_glob_list, but can in the future be modified to do more.
> > >
> > > I'm not sure if svn_string.c is the correct place for the new function;
> > > feel free to suggest a better place.
> >
> > svn_ctring.c is wrong place for this functions. It should be private
> > libsvn_wc function with name like svn_wc__match_ignore_list()
>
> It is called from libsvn_client as well (add.c, commit.c), so it can't be
> private to libsvn_wc, unless I'm misunderstanding what private means in
> this context.
>
Sorry, I missed reference from libsvn_client.
So in this case it should be public function svn_wc_match_ignore_list.
But anyway I consider it should be libsvn_wc function.

-- 
Ivan Zhakov
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jun 17 11:16:51 2006

This is an archived mail posted to the Subversion Dev mailing list.