Re: [PATCH] More tests for the svn.wc Python bindings

On Thu, 15 Jun 2006 00:35:54 +0530, Jelmer Vernooij <jelmer@samba.org>
wrote:

> Hi,
>
> [[[
> More test coverage for the svn.wc Python bindings.
>
> * subversion/bindings/swig/python/tests/wc.py
> (setUp): Acquire write lock on wc
> (tearDown): Explicitly close wc
> (test_lock): Add tests for add_lock and remove_lock
> (test_version): Add test for version()
> (test_is_adm_dir): Add test for is_adm_dir()
> (test_get_adm_dir): Add test for get_adm_dir()
> (test_set_adm_dir): Add test for set_adm_dir()
> (test_init_traversal_info): Add test for init_traversal_info()
> (test_create_notify): Add test for create_notify()
> (test_check_wc): Add test for test_wc()
>
> ]]]
>

Why is the class called SubversionRepositoryTestCase? Shouldn't it be
SubversionWorkingCopyTestCase?

Also, am not sure about this, but wont it be much clearer, if the log file
referred to the functions with the class.function() convention?

btw, could you pl. attach the patches with a .txt extension. Thanks.

Regards,
Madan.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 15 23:34:40 2006