[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [PATCH] Factorise 'svn lock' validation code

From: Lieven Govaerts <lgo_at_mobsol.be>
Date: 2006-06-14 20:25:38 CEST

Committed in r20100.

Lieven.

> -----Original Message-----
> From: rooneg@gmail.com [mailto:rooneg@gmail.com] On Behalf Of
> Garrett Rooney
> Sent: woensdag 14 juni 2006 20:21
> To: Lieven Govaerts
> Cc: Madan U Sreenivasan; Peter N. Lundblad; dev@subversion.tigris.org
> Subject: Re: [PATCH] Factorise 'svn lock' validation code
>
> On 6/14/06, Lieven Govaerts <lgo@mobsol.be> wrote:
> > Madan,
> >
> > I tried your patch but it doesn't work.
> >
> > The actual problem is cause by these two lines of code:
> >
> > comment = "Locking path:%s." % path
> > [..]
> > comment_re = re.compile (".*?%s\n.*?" % re.escape(comment),
> > re.DOTALL)
> >
> > The code does a regex match on the text(expanded): '.*Locking Path:
> > /path/to/file.*'. Problem is that on Windows, the path
> separator is a
> > backslash, which should be escaped in regular expressions.
> >
> > Attached patch will do just that, so unless you see any new
> problems
> > I'll commit it.
>
> Looks fine to me, if it works on windows commit it!
>
> -garrett
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jun 14 20:30:49 2006

This is an archived mail posted to the Subversion Dev mailing list.