Garrett Rooney wrote:
> On 6/13/06, C. Michael Pilato <cmpilato@collab.net> wrote:
>
>> Ouch. That really didn't pan out well for me. I walked away from my
>> computer to work on a different one, and when I came back, it was
>> basically
>> unresponsive (resource-strapped). Guess I crossed the stack depth
>> line of
>> no return. Anyway, a reboot later, I can confirm that my commit actually
>> happened. Post-commit deltification? I kinda doubt that finished...
>
>
> Hmm. I wonder if it's stack depth, or just memory usage. If it's
> stack depth, we can avoid that by simply rewriting the algorithm to
> not be recursive (using an explicit stack rather than the C call
> stack, etc), the problem is if we're just running out of memory
> because each level of recursion uses an APR pool the fix is far less
> straitforward...
>
> FWIW, I suspect it's not an easy fix. If you'd run out of C stack
> you'd probably have crashed, as opposed to just slowing to a crawl...
Actually, I wonder if we couldn't simply switch from a
crawl-the-tree-to-find-modified-things (recursive) approach to an
ask-the-changes-file-what-changed (iterative) approach?
--
C. Michael Pilato <cmpilato@collab.net>
CollabNet <> www.collab.net <> Distributed Development On Demand
Received on Wed Jun 14 18:49:00 2006