[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Disallow passing None for revision arguments in svn.client

From: Jelmer Vernooij <jelmer_at_samba.org>
Date: 2006-06-14 18:22:58 CEST

On Wed, 2006-06-14 at 11:27 -0400, Garrett Rooney wrote:
> On 6/14/06, Jelmer Vernooij <jelmer@samba.org> wrote:
> > Trivial patch for svn.client's Python bindings.
> >
> > [[[
> >
> > * subversion/bindings/swig/svn_client.i:
> > Disallow passing NULL revision and peg_revision arguments.
> >
> > ]]]
> What happens if you try to pass NULL? Is this something we can test?
You'll get a SIGSEGV. With this patch, you'll get a ValueError exception
instead of a crash.

Cheers,

Jelmer

-- 
Jelmer Vernooij <jelmer_at_samba.org> - http://samba.org/~jelmer/

Received on Wed Jun 14 18:32:56 2006

This is an archived mail posted to the Subversion Dev mailing list.