[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Factorise 'svn lock' validation code

From: Lieven Govaerts <lgo_at_mobsol.be>
Date: 2006-06-14 11:23:39 CEST

Quoting Garrett Rooney <rooneg@electricjellyfish.net>:

> On 5/24/06, Madan U Sreenivasan <madan@collab.net> wrote:
> > On Wed, 24 May 2006 14:46:42 +0530, Peter N. Lundblad
> > <peter@famlundblad.se> wrote:
> >
> > > Madan U Sreenivasan writes:
> > [snip]
> > > > + lock_info = output[-6:-1]
> > >
> > > While here, we could as well make this not break if we add more fields
> > > to the info output in the future. I think we should search for the
> > > specific
> > > fields, which is much easier with this refactorization.
> >
> > Aye! Aye! captain!, pl. find the patch attached. :)
> >
> > [[[
> > Factorize out code for locking a path and validating
> > the contents of the lock.
> >
> > Suggested by: djames
> > Review by: lundblad
> >
> > * subversion/tests/cmdline/svntest/actions.py
> > (run_and_validate_lock): New function to lock a path, and
> > validate the contents of the lock.
> >
> > * subversion/tests/cmdline/lock_tests.py
> > (examine_lock, examine_lock_via_url, examine_lock_encoded_recurse):
> > Modified to use svntest.actions.run_and_validate_lock().
> > ]]]
>
> Committed in r20086. Thanks,
>
> -garrett

Garrett,

this commit seems to make the test fail on the Win32/XP/VS2005 buildslave. On
Mac & Linux buildslaves it looks ok.

More info (tests.log) here:
http://www.mobsol.be/buildbot/win32-xp%20VS2005/builds/81/step-Test%20fsfs%2Bra_local/0

I don't have the time to look into it right now, if needed I can look into the
problem this evening.

Lieven.

----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jun 14 11:24:35 2006

This is an archived mail posted to the Subversion Dev mailing list.