[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r19971 - trunk/subversion/libsvn_wc

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2006-06-13 22:17:40 CEST

Stefan Küng writes:
> Peter N. Lundblad wrote:
> > Stefan Küng writes:
> > > Garrett Rooney wrote:
> > > [snip]
> > > If the error SVN_ERR_IO_INCONSISTENT_EOL is returned only if there are
> > > no other changes, we could just mark the file as unmodified and ignore
> > > the error. But if the error is returned as soon as inconsistend EOLs are
> > > found without checking the whole file for modifications, then that's not
> > > an option.
> > >
> > The latter is actually the case. I see no reason to treat this condition
> > as an error *here*.
>
> But if you treat this as an error, then what would svn_client_status2()
> return for this file? Time to introduce a new status enum field
> 'inconsistent EOLs'?
>

I suggest that we revert to the 1.3 behaviour of not treating this as an error
in status.

(Unfortunately, I'm totally lacking the time to do this.)

//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 13 22:18:20 2006

This is an archived mail posted to the Subversion Dev mailing list.