[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH][1.4.x!] Fix slew of blame issues

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: 2006-06-12 20:50:59 CEST

On 6/13/06, Madan U Sreenivasan <madan@collab.net> wrote:
> On Mon, 12 Jun 2006 13:47:53 +0530, Erik Huelsmann <ehuels@gmail.com>
> wrote:
>
> > In the thread '[RFC] 1.4.x platform dependent blame output' I opened a
> > discussion about what blame output should look like.
> >
> > If the outcome is to be that we want to change all behaviours as given
> > in that thread (and as ack-ed by djh), the patch below can be used to
> > fix the code.
> >
> > I'll be out of commit range for Tuesday until Friday, so I decided to
> > post the patch now; even without a definitive outcome of the
> > forementioned thread.
> >
> > Comments welcome!
>
> +wrap_pre3_receiver(svn_client_blame_receiver_t *receiver,
> + void **receiver_baton,
> + apr_pool_t *pool)
>
>
> wrap_pre3_receiver? How about wrap_blame_receiver?

I'll make it wrap_pre_blame3_receiver, as that's exactly what it's
meant for: to wrap a receiver which is passed into svn_client_blame or
svn_client_blame2 (but *not* svn_client_blame3).

Does that explain it?

bye,

Erik.

Thanks for the comments!

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 12 20:51:28 2006

This is an archived mail posted to the Subversion Dev mailing list.