[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add a new method, Svn::Core::LogChangedPath#copied? for the SWIG/Ruby bindings.

From: Kouhei Sutou <kou_at_cozmixng.org>
Date: 2006-06-12 14:15:44 CEST

Hi,

In <20060612.144818.74728380.nori1@dolphin.c.u-tokyo.ac.jp>
  "[PATCH] Add a new method, Svn::Core::LogChangedPath#copied? for the SWIG/Ruby bindings." on Mon, 12 Jun 2006 14:48:18 +0900 (JST),
  Kobayashi Noritada <nori1@dolphin.c.u-tokyo.ac.jp> wrote:

> Here is a patch to add a new method, Svn::Core::LogChangedPath#copied?
> implemented with Svn::Util.copy?.

+1
I'm very happy if you add a test case for your patch.
Anyway, please commit, nori.

> Please review it and its way of naming.
> # Which is better, 'copy?' or 'copied?'? ;-)

I prefer 'copied?' to 'copy?'.

Thanks,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 12 14:16:19 2006

This is an archived mail posted to the Subversion Dev mailing list.