[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: [RFC] 1.4.x platform dependent blame output

From: Lieven Govaerts <lgo_at_mobsol.be>
Date: 2006-06-11 22:28:04 CEST

Erik,

attached patch is a new blame test that will validate the result of blame
when the eol-style property is set to CR.

It's failing currently, all blame output is returned in one line instead of
three (just like you expected).

Lieven.

> -----Original Message-----
> From: Erik Huelsmann [mailto:ehuels@gmail.com]
> Sent: zondag 11 juni 2006 10:01
> To: dev
> Subject: [RFC] 1.4.x platform dependent blame output
>
> Hi!
>
> As part of solving issue #2431 (blame ignores svn:eol-style),
> blame now gives different output for (some eol) -> native
> svn:eol-style changes. Brane, Lundblad and I all agree this
> is not correct.
>
> There is also another issue: I actually think blame output is
> client output (like svn status) rather than raw output (like
> svn cat). This means the issue is invalid and needs no
> fixing: we just need to make sure we generate the right
> platform specific eols.
>
> The data passed to the blame callback is insufficiently
> defined to guarantee the right platform specific eol style,
> because it doesn't say whether the file-eols are in- or
> excluded from the line data. In practice, we pass CRs when
> the eol style is CRLF.
>
> If the eol style is CR we give completely broken results: the
> full file is passed as line 1.
>
> I'd like your comments to this:
>
> - blame output is 'client output', not 'raw output'
> - blame output should be the same for all platforms
> - we should fix the callback to use the right eol style
> - we should fix the line data to be better defined
> - all the above needs to be done before 1.4.0 final (I have
> the patches)
>
> Thanks for your comments!
>
> bye,
>
> Erik.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Sun Jun 11 22:32:56 2006

This is an archived mail posted to the Subversion Dev mailing list.