[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: BDB 4.4 + forking svnserve weirdness (issue 2564)

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2006-06-08 03:40:49 CEST

On Wed, 2006-06-07 at 21:38 -0400, Garrett Rooney wrote:
> I'm sorry, I misspoke. It's not that it's paniced, it's that it's
> invalidated (see the invalidate_env_baton callback in
> libsvn_fs_base/bdb/env.c). I believe it's part of the infrastructure
> that keeps you from running close twice on the same bdb environment.
> When the bdb env cache pool is destroyed it invalidates all
> outstanding cached environments. I'm not entirely clear on the
> details, but I expect it's something related to making sure we don't
> access memory after its pool is destroyed.

So, we had a big discussion of this issue in the past, and I thought we
came up with a proper solution, where destroying the cache pool would
cleanly close the environments, and subsequent destruction of the FS
object pools would do nothing. If we didn't, then Branko must have
messed up, and I don't think the fix is to force the pool destruction
order in svnserve or any other program.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 8 03:41:21 2006

This is an archived mail posted to the Subversion Dev mailing list.