[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r19962 - trunk/subversion/bindings/swig/python/tests

From: David James <djames_at_collab.net>
Date: 2006-06-06 19:10:46 CEST

On 6/6/06, maxb@tigris.org <maxb@tigris.org> wrote:
> Remove Python-2.4-isms from the Python bindings testsuite -
> use unittest.TestCase.assert_(), not unittest.TestCase.assertTrue().

Hey Max,

Thanks for fixing this! However, I'm not sure this is the right fix.

Instead of replacing 'assertTrue' with 'assert_', could we just write
a compatibility wrapper function called 'assertTrue', which delegates
to either assert_ or assertEqual(x, true)? assertTrue is a much better
name for the function than 'assert_'.

Cheers,

David

-- 
David James -- http://www.cs.toronto.edu/~james
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 6 19:11:12 2006

This is an archived mail posted to the Subversion Dev mailing list.