Re: Version 1.4.0: svn st errors out

Garrett Rooney wrote:
> On 6/6/06, Stefan Küng <tortoisesvn@gmail.com> wrote:
>> Garrett Rooney wrote:
>> > On 6/6/06, C. Michael Pilato <cmpilato@collab.net> wrote:
>> >
>> >> I have not reproduced this problem either -- am just reading code.
>> >> So, what
>> >> previously I writ, and what followeth from my hand, might be, as they
>> >> say in
>> >> the Greek, "hogwash".
>> >
>> > Well, in the spirit of totally untested fixes, here's a patch that may
>> > do it...
>> >
>> > Stefan, if you could give this a shot, I'd appreciate it.
>>
>> Sorry, but I still get the error "inconsistent line ending style".
>> I'll try stepping through the code and see what I can find out...
>
> Building in maintainer mode (is there an easy way to do that on
> win32?) would be useful, as it could tell you the line number and file
> the error is originating in, which means its easy to get a backtrace
> and figure out where the error isn't getting handled...

Good point! Actually, I have a debug build ready, but for some unknown
reason I used the release build to test it.

But I found it anyway by stepping through the code. Your patch checks
the return value in line 302 in file questions.c. But the function
actually fails some lines below:

       if (! v_stream)
         {
           same = FALSE;
         }
       else
         {
           SVN_ERR(svn_stream_contents_same(&same, b_stream, v_stream,
pool));

           SVN_ERR(svn_stream_close(v_stream));
         }

It fails in svn_stream_contents_same(), there the error
SVN_ERR_IO_INCONSISTENT_EOL is returned.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org