[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Replace svn_io_set_file_read_write_carefully

From: D.J. Heap <djheap_at_gmail.com>
Date: 2006-06-03 20:09:34 CEST

Any objections to the attached patch? Its a step toward supporting
Apache 2.2/APR 1.x on Win32.

Log:
Replace svn_io_set_file_read_write_carefully with
svn_io_set_file_read_write_perms which has been updated to work with
APR 1.x behavior on Win32.

It's behavior on unix style OS' is unchanged, but on Win32 it now just
forwards the calls to the appropriate svn_io_set_file_read_* functions.

Setting permissions on Win32 is unimplemented in APR, and Win32's
inherited ACL's do the right thing anyway on filesystems that support
permissions.

See this email thread for previous discussion:
http://svn.haxx.se/dev/archive-2006-02/0747.shtml

* subversion/include/svn_io.h
  Deprecate svn_io_set_file_read_write_carefully and declare
  new svn_io_set_file_read_write_perms function.

* subversion/libsvn_wc/props.c
  (svn_wc_prop_set2): Use new function.

* subversion/libsvn_wc/log.c
  (install_committed_file): Ditto.

* subversion/libsvn_wc/adm_ops.c
  (svn_wc_add_lock, svn_wc_remove_lock): Ditto.

* subversion/libsvn_wc/translate.c
  (svn_wc__maybe_set_read_only): Ditto.

* subversion/libsvn_subr/io.c
  (svn_io_set_file_read_write_perms): Implement new function.
  (svn_io_set_file_read_write_carefully): Forward call to new function.

DJ

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Sat Jun 3 20:09:59 2006

This is an archived mail posted to the Subversion Dev mailing list.