[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r19838 - trunk/build

From: Ben Reser <ben_at_reser.org>
Date: 2006-06-01 00:24:47 CEST

On 5/30/06, Daniel Rall <dlr@collab.net> wrote:
> Isn't self.log usually tests.log? From main():
>
> th = TestHarness(args[0], args[1],
> os.path.abspath('tests.log'),
> base_url, fs_type, verbose, cleanup)
>
> Logging a message saying "look in the log file" to the log file itself
> doesn't seem particularly useful. :-P
>
> Also, the message itself could use a comma between the words "failure"
> and "see."

Yes but the whole point of writing that message is to make it so the
comment shows in the summary at the end. Most people are going to see
the summary first. Since there's no good way for me to have the
summary pull the proper error output out like it would for most other
failures, I put text there to point people to look for the full
information in the log file.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jun 1 00:25:17 2006

This is an archived mail posted to the Subversion Dev mailing list.