[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r19869 - trunk/subversion/libsvn_repos

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-05-31 18:39:14 CEST

On Wed, 31 May 2006, pburba@tigris.org wrote:
...
> Fix hook script processing bug on OS400.
>
> Follow-up to r19004 and r19166, fix potential corruption of hook
> script's stderr message.
>
> * subversion/libsvn_repos/hooks.c
> (run_hook_cmd): NULL terminate stderr message in stringbuf.
...
> --- trunk/subversion/libsvn_repos/hooks.c (original)
> +++ trunk/subversion/libsvn_repos/hooks.c Wed May 31 05:53:47 2006
> @@ -302,7 +302,11 @@
> /* If read() returned 0 then EOF was found and we are done reading
> * stderr. */
> if (rc == 0)
> - break;
> + {
> + /* Null terminate the stringbuf. */
> + script_output->data[script_output->len] = '\0';
> + break;
> + }
> }

The inline comment is extraneous.

-- 
Daniel Rall

  • application/pgp-signature attachment: stored
Received on Wed May 31 18:40:50 2006

This is an archived mail posted to the Subversion Dev mailing list.