Isn't self.log usually tests.log? From main():
th = TestHarness(args, args,
base_url, fs_type, verbose, cleanup)
Logging a message saying "look in the log file" to the log file itself
doesn't seem particularly useful. :-P
Also, the message itself could use a comma between the words "failure"
On Fri, 26 May 2006, email@example.com wrote:
> Author: breser
> Date: Fri May 26 18:03:18 2006
> New Revision: 19838
> Make tests that fail to run at all show in error summary.
> * build/run_tests.py
> (_run_test): Watch for exit codes other than 1 and add a FAIL
> notation to the log file so the summary picks up
> the failure.
> Modified: trunk/build/run_tests.py
> URL: http://svn.collab.net/viewvc/svn/trunk/build/run_tests.py?pathrev=19838&r1=19837&r2=19838
> --- trunk/build/run_tests.py (original)
> +++ trunk/build/run_tests.py Fri May 26 18:03:18 2006
> @@ -122,7 +122,13 @@
> - if failed:
> + # We always return 1 for failed tests, if some other failure than 1
> + # probably means the test didn't run at all and probably didn't
> + # output any failure info.
> + if failed == 1:
> + print 'FAILURE'
> + elif failed:
> + print >> self.log, 'FAIL: ' + progbase + ': Unknown test failure see tests.log.\n'
> print 'FAILURE'
> print 'success'
Received on Wed May 31 02:55:08 2006
- application/pgp-signature attachment: stored