[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r19838 - trunk/build

From: Daniel Rall <dlr_at_collab.net>
Date: 2006-05-31 02:54:34 CEST

Isn't self.log usually tests.log? From main():

  th = TestHarness(args[0], args[1],
                   os.path.abspath('tests.log'),
                   base_url, fs_type, verbose, cleanup)

Logging a message saying "look in the log file" to the log file itself
doesn't seem particularly useful. :-P

Also, the message itself could use a comma between the words "failure"
and "see."

- Dan

On Fri, 26 May 2006, breser@tigris.org wrote:

> Author: breser
> Date: Fri May 26 18:03:18 2006
> New Revision: 19838
>
> Modified:
> trunk/build/run_tests.py
>
> Log:
> Make tests that fail to run at all show in error summary.
>
> * build/run_tests.py
> (_run_test): Watch for exit codes other than 1 and add a FAIL
> notation to the log file so the summary picks up
> the failure.
>
>
> Modified: trunk/build/run_tests.py
> URL: http://svn.collab.net/viewvc/svn/trunk/build/run_tests.py?pathrev=19838&r1=19837&r2=19838
> ==============================================================================
> --- trunk/build/run_tests.py (original)
> +++ trunk/build/run_tests.py Fri May 26 18:03:18 2006
> @@ -122,7 +122,13 @@
> else:
> os.chdir(old_cwd)
>
> - if failed:
> + # We always return 1 for failed tests, if some other failure than 1
> + # probably means the test didn't run at all and probably didn't
> + # output any failure info.
> + if failed == 1:
> + print 'FAILURE'
> + elif failed:
> + print >> self.log, 'FAIL: ' + progbase + ': Unknown test failure see tests.log.\n'
> print 'FAILURE'
> else:
> print 'success'

  • application/pgp-signature attachment: stored
Received on Wed May 31 02:55:08 2006

This is an archived mail posted to the Subversion Dev mailing list.