[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix svn_log_changed_path_dup()

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2006-05-30 16:41:14 CEST

Left this part (the review of your log message) out of my previous email on
the subject. Read on.

Madan U Sreenivasan wrote:
> [[[
> Fix svn_log_changed_path_dup().
>
> * subversion/libsvn_subr/constructors.c
> (svn_log_changed_path_dup): Fix the function.
> Modified to achieve the following:

"Fix the function"? "Modified to achieve the following"? This is a log
message, Madan -- you'll be graded on quality, not quantity. You can say
every bit of what you said in as little text as this:

   (svn_log_changed_path_dup): Add comments for clarity, unconditionally
     copy the 'copyfrom_path' member, and explicitly copy the 'copyfrom_rev'
     member.

But as was noted in my other mail, this change is basically entirely
incorrect. :-(

> - Add comment for copying the `action' member variable

That code wasn't copying the 'action' member variable (at least, not directly).

> - Fix copy of the `copyfrom_path' member variable

"Fix" means almost nothing. Tell us what was broken.

> - Copy `copyfrom_rev' member variable

As pointed out elsewhere, this was unnecessary.

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on Tue May 30 16:48:06 2006

This is an archived mail posted to the Subversion Dev mailing list.