Re: [PATCH] Fix svn_log_changed_path_dup()
From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2006-05-30 16:41:14 CEST
Left this part (the review of your log message) out of my previous email on
Madan U Sreenivasan wrote:
"Fix the function"? "Modified to achieve the following"? This is a log
(svn_log_changed_path_dup): Add comments for clarity, unconditionally
But as was noted in my other mail, this change is basically entirely
> - Add comment for copying the `action' member variable
That code wasn't copying the 'action' member variable (at least, not directly).
> - Fix copy of the `copyfrom_path' member variable
"Fix" means almost nothing. Tell us what was broken.
> - Copy `copyfrom_rev' member variable
As pointed out elsewhere, this was unnecessary.
-- C. Michael Pilato <firstname.lastname@example.org> CollabNet <> www.collab.net <> Distributed Development On Demand
This is an archived mail posted to the Subversion Dev mailing list.