[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] add shebang line to build/run_tests.py

From: Madan U Sreenivasan <madan_at_collab.net>
Date: 2006-05-30 12:42:32 CEST

Hi,

    Pl. find a patch that adds the shebang line (#!/usr/bin/env python) to
build/run_tests.py. As a consequence, the svn:executable property had to
be added to build/run_tests.py and the Makefile.in modified to run
run_tests.py directly (instead of 'python run_tests.py').

    OMG, the Makefile.in is full of tabs, could some committer fix this pl?
Or is it there on purpose?

    Another thing am not sure about. I just added the copyright message to
build/run_tests.py. Should the start year of the copyright be 2006 or the
year when the script was created?

Regards,
Madan.

PS : Contents below are for my personal patch management. Pl. do not
remove the below text while replying to this mail.
MY-SVK-TAG: addpyhashbang

=== Makefile.in
==================================================================
--- Makefile.in (revision 596)
+++ Makefile.in (local)
@@ -381,7 +381,7 @@
           if test "$(FS_TYPE)" != ""; then \
             flags="--fs-type $(FS_TYPE) $$flags"; \
           fi; \
- $(PYTHON) $(top_srcdir)/build/run_tests.py $$flags \
+ $(top_srcdir)/build/run_tests.py $$flags \
                     '$(abs_srcdir)' '$(abs_builddir)' $(TESTS); \
         else \
           echo "make check: Python 2.0 or greater is required,"; \
=== build/run_tests.py
==================================================================
--- build/run_tests.py (revision 596)
+++ build/run_tests.py (local)
@@ -1,8 +1,19 @@
+#!/usr/bin/env python
 #
 # run_tests.py - run the tests in the regression test suite.
 #
+# ====================================================================
+# Copyright (c) 2006 CollabNet. All rights reserved.
+#
+# This software is licensed as described in the file COPYING, which
+# you should have received as part of this distribution. The terms
+# are also available at http://subversion.tigris.org/license-1.html.
+# If newer versions of this license are posted there, you may use a
+# newer version instead, at your option.
+#
+######################################################################
 
-'''usage: python run_tests.py [--url=<base-url>] [--fs-type=<fs-type>]
+'''usage: run_tests.py [--url=<base-url>] [--fs-type=<fs-type>]
                     [--verbose] [--cleanup]
                     <abs_srcdir> <abs_builddir>
                     <prog ...>

Property changes on: build/run_tests.py
___________________________________________________________________
Name: svn:executable
 +on

Add shebang line to build/run_tests.py

* Makefile.in
  (check): Modified to execute build/run_tests.py directly.
* build/run_tests.py
  (svn:executable) : Set property to 'on'.
  (shebang line): Added.
  (Copyright text): Added.
  (usage text): Modified to reflect that the script can be invoked directly.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 30 12:12:55 2006

This is an archived mail posted to the Subversion Dev mailing list.