Re: svn commit: r19823 - in branches/merge-tracking: . subversion/tests/libsvn_subr

Garrett Rooney wrote:
> On 5/25/06, dlr@tigris.org <dlr@tigris.org> wrote:
>
>> + /* Trigger some error(s) with mal-formed input. */
>> + err = svn_parse_mergeinfo(BOGUS_MERGEINFO_LINE,
>> &path_to_merge_ranges,
>> + pool);
>> + if (!err)
>> + return svn_error_createf(SVN_ERR_TEST_FAILED, NULL,
>> + "svn_parse_mergeinfo (%s) succeeded "
>> + "unexpectedly", BOGUS_MERGEINFO_LINE);
>
>
> Probably want a svn_error_clear here.

Or, nest the error so folks can see the specifics of the failure.

    return svn_error_createf(SVN_ERR_TEST_FAILED, err,
                             "svn_parse_mergeinfo (%s) succeeded "
                             "unexpectedly", BOGUS_MERGEINFO_LINE);

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand