[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: setting ra_callbacks.open_tmp_file from python bindings?

From: Gregory (Grisha) Trubetskoy <grisha_at_apache.org>
Date: 2006-05-24 18:50:27 CEST

On Tue, 23 May 2006, Jelmer Vernooij wrote:

>> This is subversion 1.3.1.
>>
>> subversion/libsvn_ra_dav/commit.c:1339
>>
>> /* Use the client callback to create a tmpfile. */
>> SVN_ERR(file->cc->ras->callbacks->open_tmp_file
>> (&baton->tmpfile,
>> file->cc->ras->callback_baton,
>> file->pool));
>>
>> ...because file->cc->ras->callbacks->open_tmp_file is null, unless you set it
>> to something.
>>
>> But can you set it from python? I tried (based on a comment I saw in swig
>> bindings somewhere):
> At the moment, you can't, indeed. I've got a half finished patch that
> implements this, but I haven't bothered to finish it yet. I'll try to

If you could share the patch, that'd be great. Getting the 'ra' to work in
Python would be fantastic and I'll be happy to help with whatever I can.

BTW, the above code could also be classified as a bug - it should test
callbacks->open_tmp_file before calling it and not assume that it's there.
I'm not up on the svn-dev community bug reporting protocol, so I thought
I'd just mention it in here for now, until I figure out how things work
here.

Grisha

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 24 18:51:03 2006

This is an archived mail posted to the Subversion Dev mailing list.