Re: svn commit: r19777 - in trunk/subversion: libsvn_client tests/cmdline

Yeah, everything else seemed fine to me, too.

Thanks guys!

- Dan

On Tue, 23 May 2006, Ben Reser wrote:

> On 5/23/06, Madan U Sreenivasan <madan@collab.net> wrote:
> >Did you miss out...
> >
> >(test_list) : Add examine_lock_encoded_recurse() test.
>
> Yup looks like dlr fixed it already.
>
> >> Modified: trunk/subversion/libsvn_client/info.c
> >> URL:
> >>
> >http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_client/info.c?pathrev=19777&r1=19776&r2=19777
> >>
> >==============================================================================
> >> --- trunk/subversion/libsvn_client/info.c (original)
> >> +++ trunk/subversion/libsvn_client/info.c Tue May 23 01:49:50 2006
> >> @@ -157,6 +157,8 @@
> >> fs_path = svn_path_is_child(repos_root, URL, subpool);
> >> fs_path = apr_pstrcat(subpool, "/", fs_path, NULL);
> >> + fs_path = svn_path_uri_decode(fs_path, subpool);
> >> +
> >
> >There are a few extra spaces just before these lines (exactly on line
> >157). Could you also pl. take care of that.
>
> I'm not seeing the extra spaces here. And doesn't seem like anyone
> has fixed it either.
>
> >> + # Run info and check that we get the lock fields.
> >> + output, err = svntest.actions.run_and_verify_svn(None, None, [],
> >> + 'info', '-R',
> >> +
> >svntest.main.current_repo_url + '/A/B/F')
> >
> >There are a few tabs there...
>
> Bitten by OS X's vim being configured different than I'm used to.
>
> >> +
> >> + lock_info = output[-6:-1]
> >> + if ((len(lock_info) != 5)
> >> + or (lock_info[0][0:28] != 'Lock Token: opaquelocktoken:')
> >> + or (lock_info[1] != 'Lock Owner: ' + svntest.main.wc_author
> >> + '\n')
> >> + or (lock_info[2][0:13] != 'Lock Created:')
> >> + or (lock_info[4] != comment + '\n')):
> >> + raise svntest.Failure
> >
> >line specific comparisons? Does this work with '--enable-maintainer-mode'
> >AND otherwise?
>
> Yes and yes. This isn't the first time in that test file we test for
> lock output from info that way.
> Also I put the test file in a directory by itself so it would always
> be the list item listed.