[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r19782 - in branches/changelist-feature/subversion: include libsvn_client svn

From: Ben Collins-Sussman <sussman_at_red-bean.com>
Date: 2006-05-23 20:54:55 CEST

On 5/23/06, C. Michael Pilato <cmpilato@collab.net> wrote:

> David seems to be thinking of it as a subtractive filtering mechanism, as in
> "Narrow the list of targets of this operation down to only those which are
> in the changelist FOO". You are proposing it as additive: "Add to the list
> of explicitly mentioned targets those items which are in the changelist FOO."

Ah, thanks for explaining it.

Yes, I'm proposing that '--changelist foo' just add more targets to
the master list of targets, the same way that '--targets filename'
does. So in the end, the targets to a command can come from any
combination of three sources: --targets, --changelist, and ones that
are hand-typed on the commandline.

On 5/23/06, Garrett Rooney <rooneg@electricjellyfish.net> wrote:

> > +svn_error_t *
> > +svn_client_retrieve_changelist(apr_array_header_t **paths,
> > + const char *changelist_name,
> > + const char *root_path,
> > + svn_cancel_func_t cancel_func,
> > + void *cancel_baton,
> > + apr_pool_t *pool);
> > +
>
> In the past we've had to go from functions like this that gather up
> all their return values and pass them back in an array to streamy
> interfaces that use a callback/baton pair. Would it make sense to
> just start this with the streamy version? I mean you can build the
> current interface on top of a callback driven version, but not the
> other way around...

What's would be the motivation to make this API streamy? It can't be
a matter of 'perceived user response time' (a la 'svn status'),
because we're just gathering targets to feed to the subcommand,
there's nothing to print. Is it a matter of trying to bound memory
usage? I don't think that's relevant here either, since every
subcommand always holds the whole array of targets in memory anyway
(which we're just augmenting with some crawl results).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 23 20:55:27 2006

This is an archived mail posted to the Subversion Dev mailing list.