[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: crash with incomplete url

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2006-05-23 14:51:56 CEST

Stefan Küng writes:

> I'd say that a library always should check (and reject if necessary)
> all inputs and not crash.

This has been discussed before, and a C library can't do that, however...

> But in this case, I think this is more important than usual. Because
> an url like 'svn+ssh://' is a valid url according to the specs, but
> not for Subversion. So how can you expect clients using your library
> to know what urls are valid for Subversion and which ones are not?
> Since only Subversion knows what it considers valid, it should also do
> the checking.

My position on this is that svn_path_canonicalize should not crash fro
any string, and no library function should crash on any string
returned by svn_path_canonicalize. So, I agree with Stefan. This is
a corner-case, in which we're misbehaving.

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 23 14:52:40 2006

This is an archived mail posted to the Subversion Dev mailing list.