[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Show] Re: svn commit: r19760 - in trunk/subversion: mod_dav_svn tests/cmdline

From: Peter N. Lundblad <peter_at_famlundblad.se>
Date: 2006-05-23 13:50:28 CEST

Madan U Sreenivasan writes:
> > Modified: trunk/subversion/tests/cmdline/diff_tests.py
> > URL:
> > http://svn.collab.net/viewvc/svn/trunk/subversion/tests/cmdline/diff_tests.py?pathrev=19760&r1=19759&r2=19760
> > ==============================================================================
> > --- trunk/subversion/tests/cmdline/diff_tests.py (original)
> > +++ trunk/subversion/tests/cmdline/diff_tests.py Mon May 22 16:28:54 2006
> > @@ -2495,6 +2495,43 @@
> > None, None, None, None,
> > wc_dir, '-r1:2')
> > +def diff_weird_author(sbox):
> > + "diff with svn:author that has < in it"
> [snip]
> > + svntest.main.run_svn(None, "propset", "--revprop", "-r", "2",
> > "svn:author",
> > + "J. Random <jrandom@example.com>", sbox.repo_url)
>
> Shouldnt we be checking for the absence of an error message here?
>

Good catch! This needs to make sure the author prop is actually set
(or at least that the expected output is received). Else, the
test could succeed even if setting the author fail.s

Regards,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 23 13:51:09 2006

This is an archived mail posted to the Subversion Dev mailing list.