[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r19732 - trunk/subversion/tests/cmdline

From: Lieven Govaerts <lgo_at_mobsol.be>
Date: 2006-05-22 09:31:37 CEST

Quoting Madan U Sreenivasan <madan@collab.net>:

> Am not a committer, but these are things I learnt from other committers...
> - the second line of the log need to be indented with only only space,
> like thus:
> > (authz_log_and_tracing_test): renamed function from authz_log_test.
> > include new testcases
>
> - The following line should be added:
> (test_list): Renamed to call authz_log_and_tracing_test() instead of
> authz_log_test().
>
> This is just my comment:
> - You could add the following:
> (authz_log_test): Renamed to authz_log_and_tracing_test().
>
> and mention the newly added features under the
> authz_log_and_tracing_test() section.

You're absolutely right.

I changed the log message to include your remarks (and one from lundblad
yesterday concerning lines < 80 chararcters).

thanks for your review,

Lieven.

----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon May 22 09:32:09 2006

This is an archived mail posted to the Subversion Dev mailing list.