[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

crash with incomplete url

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2006-05-21 18:12:10 CEST


Had some time to go through all the crashreports I got for TSVN:

If a valid (but not very usable, I admit) url is passed to some (or
all?) Subversion API's, it will crash.
Unfortunately, I can't reproduce this with the CL client, I guess it's
because it parses the URL first for peg revisions and that function
errors out for such urls. But the API should error out too if it can't
do anything with the url - most other clients don't have the pegrev
syntax as the CL client and therefore don't use that checking function.

For example, passing "svn+ssh:" as the URL to svn_client_ls() will crash
in svn_path_uri_decode(), because the path is NULL. That's because in
the outer function find_tunnel_agent(), the hostinfo string is NULL
(which is of course correct, because there is no hostinfo in that url).

This applies to Subversion 1.3.1, the 1.4.x branch and trunk.


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.tigris.org
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun May 21 18:12:41 2006

This is an archived mail posted to the Subversion Dev mailing list.