[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn log wcpath@BASE in 1.4.x fails

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-05-17 21:30:28 CEST

On 5/17/06, Madan U Sreenivasan <madan@collab.net> wrote:
> On Wed, 17 May 2006 02:28:46 +0530, Garrett Rooney
> <rooneg@electricjellyfish.net> wrote:
>
> > On 5/15/06, Stefan Küng <tortoisesvn@gmail.com> wrote:
> >> Hi,
> >>
> >> I don't know exactly when this happened, but for some time now an
> >>
> >> svn log path\to\wc\file@BASE
> >>
> >> fails
> [snip]
> > The underlying problem is caused by passing a revision that requires a
> > working copy path to figure out (@BASE, @COMMITTED, @PREV) to
> > svn_client__ra_session_from_path along with a URL instead of a working
> > copy path. I've got a fix, but I'm not sure if it's completely right.
> > It'll work for those cases, so it's certainly an improvement, but I'm
> > not clear what should be done when we have multiple targets...
>
> IMHO, it doesnt matter... we should also remove the targets->nelts == 1
> check
>
> > How do
> > you know where to root the session at?
>
> Unless we receive an empty string in 'target' after the call to
> svn_path_condense_target, we should root it at 'target' (your patch
> already does this).
> 'target' would be an empty string, only if the paths given belong to two
> different working copies (Do we handle this case for other svn commands?)
>
> > It's not even certain to be a
> > wc path according to the docs of svn_path_condense_targets...
>
> I interpret it as : The first common string sequence irrespective of
> whether its a wc path or not. Means... junk in, junk out. wc path in, wc
> path out.

Actually, it turns out it doesn't matter. svn_client_log3
specifically requires one argument, then if that argument is a URL it
can have several paths relative to that argument. So any valid use of
it is still correct with this new check.

> > Anyway, here's a patch for the single target case.
>
> I think your patch is good, but for the removal of targets->nelts == 1
> check...

I'm doing that, plus adding an actual check to error out with a more
useful error message if you try to use @BASE or something like it with
a URL.

Commit coming soon.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 17 21:31:11 2006

This is an archived mail posted to the Subversion Dev mailing list.