[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn log wcpath@BASE in 1.4.x fails

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-05-16 22:58:46 CEST

On 5/15/06, Stefan Küng <tortoisesvn@gmail.com> wrote:
> Hi,
>
> I don't know exactly when this happened, but for some time now an
>
> svn log path\to\wc\file@BASE
>
> fails with
> svn: Can't check path 'file:\\\path\to\repository\location\of\file': Die
> Syntax für den Dateinamen, Verzeichnisnamen oder die
> Datenträgerbezeichnung ist falsch.
>
> (sorry for the german error text, it's an OS error and means something
> like "the syntax for the filename, directoryname or the drive name is
> wrong").
>
> All this with the latest version compiled from the 1.4.x branch:
> svn --version
> svn, version 1.4.0 (dev build)
> compiled May 15 2006, 18:05:14
>
> Stefan
>
> P.S. The same error happens for https:// based working copies, and it
> also fails for @COMMITTED, @PREV, and svn_opt_revision_working if passed
> directly via svn_client_log3().

The underlying problem is caused by passing a revision that requires a
working copy path to figure out (@BASE, @COMMITTED, @PREV) to
svn_client__ra_session_from_path along with a URL instead of a working
copy path. I've got a fix, but I'm not sure if it's completely right.
 It'll work for those cases, so it's certainly an improvement, but I'm
not clear what should be done when we have multiple targets... How do
you know where to root the session at? It's not even certain to be a
wc path according to the docs of svn_path_condense_targets...

Anyway, here's a patch for the single target case.

-garrett

[[[
Fix 'svn log working/copy/file@BASE'.

Reported by: Stefan Küng <tortoisesvn@gmail.com>

* subversion/libsvn_client/log.c
  (svn_client_log3): Don't pass a URL into svn_client__ra_session_from_path
   when our peg revision requires a working copy path to figure out.
]]]

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Tue May 16 22:59:21 2006

This is an archived mail posted to the Subversion Dev mailing list.