[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]Fixed a few typos

From: David James <djames_at_collab.net>
Date: 2006-05-15 21:40:10 CEST

On 5/14/06, Vlad Georgescu <vgeorgescu@gmail.com> wrote:
> Fixed a few typos

Thanks for your attention to detail, Vlad! I've committed your patch in r19647.

I updated your log message to include the names of the functions which
were changed. Please see my updated log message below.

[[[

Fixed a few typos in comments for libsvn_client.

Patch by: Vlad Georgescu <vgeorgescu@gmail.com>

[ In subversion/libsvn_client ]

* externals.c
  (switch_external): Replaced 'revison' with 'revision'.
* client.h
  (svn_client__wc_delete): Replaced 'modifed' with 'modified'.
  (svn_client__get_diff_editor): Replaced 'calback' with 'callback'.
* diff.c
  (diff_content_changed): Replaced 'instread' with 'instead'.
  (diff_parameters): Replaced 'acestry' with 'ancestry'.
* commit_util.c
  (harvest_committables): Replaced 'comparitive' with 'comparative'.
* commit.c
  (svn_client_import2): Replaced 'asethetically' with 'aesthetically'
  (reconcile_errors): Replaced 'decendant' with 'descendant'.
* add.c
  (svn_client_mkdir2): Replaced 'directoies' with 'directories'.

]]]

A few handy tips for writing log messages:

1. I listed the function names before each change. In a simple typo
fix like this, the function names are not that important, but if you
are making a more serious change which changes the behaviour or
documentation of the function, it is important to list the function
name so that people can find out when the function was changed by
grepping through the log.
2. I referenced "subversion/libsvn_client" at the top of my log
message so that I didn't have to write it separately for each file.

Here's a handy trick I use to help me find the function names for each
log message:
   svn diff --diff-cmd=`which diff` -x'-u20 -p'

This makes it easier to find the function names quickly. Notice that
the current 'function name' appears at the top of each diff chunk, so
you can still see what function a change is appearing in, even if your
change is in the middle of a long function.

Cheers,

David

-- 
David James -- http://www.cs.toronto.edu/~james
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon May 15 21:40:46 2006

This is an archived mail posted to the Subversion Dev mailing list.