[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] mail address handling and option mapping in mailer.py

From: Mathias Weinert <mathias.weinert_at_gfa-net.de>
Date: 2006-05-15 16:57:15 CEST

Mathias Weinert wrote:

> Malcolm Rowe wrote:
>
> > On Wed, May 03, 2006 at 11:05:52AM +0200, Mathias Weinert wrote:
> > > * tools/hook-scripts/mailer/mailer.py
> > > - new option 'to_addr_split_char' added which allows to use another character but the default whitespaces to separate different mail addresses
> >
> > I don't know much about mailer.py, so this may be a silly question, but it
> > might help reviewers if you could summarise why this is a useful feature.
>
> I summarised it in my original post. But you are right, I should have
> summarised it again.
>
> >
> > Why would someone ever need to use a non-whitespace separator to provide
> > a list of email addresses?
> >
>
> This is usefull for using additional name information in the mail
> addresses. Example:
>
> to_addr_split_char = ,
> to_addr = "The great Wallace" <wallace@atanyaddress>, "little Grommit" <grommit@propablyatthesameaddress>
>
> This was the simple example (which doesn't make so much sense).
> A more reasonable example is the following one:
>
> [defaults]
> from_addr = %(author)s
>
> [maps]
> from_addr = [mail_addresses]
> to_addr = [mail_addresses]
>
> [mail_addresses]
> wallace = "SVN: Wallace" <wallace@atanyaddress>
> grommit = "SVN: Grommit" <grommit@propablyatthesameaddress>
>
> [config_for_wallace]
> to_addr = wallace
> ...
>
> With this I at least don't use the comma as separator but don't
> use the whitespaces any more and am therefor able to use one set
> of mail addresses containing blanks which I use for the to_addr
> as well as for the from_addr. So I have the mail address only
> once in the config file and the mails that are sent can easily
> be identified in the mail client by the address which starts with
> 'SVN: '.
> For me this is a really usefull thing.
>
> > > - it's now possible to use capital letters in option values which will be passed through a map
> >
> > This doesn't look like it's related to the change above, so you're
> > probably better off sending two separate patches (unless the two changes
> > really are related).
> >
>
> You are right, they aren't related at all. I once posted them
> together at it were only little changes - and I agree that I should
> have sent them separatly. I'll do so next time.
>
> Mathias

Does it help if I will send two separate patches in this special case or
is someone willing to divide my patch file and make two commits - or at
least commit one of them (I still haven't give up hope that one day my
changes will be committed)?

Many thanks in advance

Mathias

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon May 15 16:57:52 2006

This is an archived mail posted to the Subversion Dev mailing list.