[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r19566 - trunk/subversion/bindings/swig/python/tests

From: Madan U Sreenivasan <madan_at_collab.net>
Date: 2006-05-09 19:31:30 CEST

On Tue, 09 May 2006 22:26:42 +0530, Garrett Rooney
<rooneg@electricjellyfish.net> wrote:

> On 5/9/06, C. Michael Pilato <cmpilato@collab.net> wrote:
>> Madan U Sreenivasan wrote:
>> > I was told once that the order of log entries must be the same as it
>> > appears in the diff... just pointing out...
>>
>> Dunno who told you that, but hacking.html sez nothing about tying the
>> log
>> message ordering to the diff ordering. (And if it did, I'd move to
>> strike
>> that micromanaging nonsense from the document.)
>>
>> I try write log messages with an inside-out sort of approach, like I
>> would
>> write the code. Generally, the stuff at the top of my log messages are
>> the
>> bits where some new function has been created (or some old one given a
>> new
>> parameter, etc.). After that come that callers of that new
>> functionality.
>> Finally, the test cases.
>
> I tend to order the logs in whatever way makes sense to me, headers go
> near the files where the functions within them live, etc. But as Mike
> says, there's no enforced order of any kind.

I guess I was told so, so that the committer could follow the log as he
read the patch, without having to search through the log.

Regards,
Madan.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 9 19:01:21 2006

This is an archived mail posted to the Subversion Dev mailing list.