[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] new python authz tests

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2006-05-06 01:33:19 CEST

On 5/5/06, Lieven Govaerts <lgo@mobsol.be> wrote:
> Hi,
>
>
> attached patch will expand the coverage of the python authz tests.
>
> While the patch doesn't cover all possible authz scenario's (no test for
> properties now), both positive and (mostly)negative read/write access for
> files&folders manipulations is covered. I choose to only use direct
> repository actions instead of going through the working copy. I suppose by
> doing this I don't skip any authz validations?
>
> Currently only ra_svn is supported. The two tests authz_read_access &
> authz_write_access both write a custom authz file in the generated test
> repository. If someone knows how to make these tests function over the
> ra_dav layer, please let me know.
>
> I see this as a first step in complete authz test coverage, any input is
> welcome.

Looks good at first glance, although there's a bunch of unnecessary
whitespace changes, which should happen separately if at all. Also,
you should be able to test authz over DAV now, see the tests at the
end of svnsync_tests.py to see how it works. If you could test to see
that these work correctly over DAV it would be much appreciated.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat May 6 01:33:43 2006

This is an archived mail posted to the Subversion Dev mailing list.