[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r19476 - trunk/subversion/svn

From: Justin Erenkrantz <justin_at_erenkrantz.com>
Date: 2006-05-05 18:51:29 CEST

On 4/29/06, brane@tigris.org <brane@tigris.org> wrote:
> Flush stdout after every line of status output. This is useful when
> piping svn output into post-processor tools, e.g. to colorize the
> output, or simply into tee.

Once again, I think this is an incredibly bad change. This patch
promotes bad behavior by lazy developers who want to treat Subversion
as CVS by building dumb wrapper scripts.

That said, this commit adds dead code - see the snippet below. Please fix.

If you leave it to me, I'll revert the entire commit. -- justin

==============================================================================
> --- trunk/subversion/svn/notify.c (original)
> +++ trunk/subversion/svn/notify.c Sat Apr 29 10:42:21 2006
> @@ -344,7 +344,6 @@
>
> if ((err = svn_cmdline_printf(pool, ".")))
> goto print_error;
> - fflush(stdout);
> break;
>
> case svn_wc_notify_locked:
> @@ -370,6 +369,9 @@
>
> return;
>
> + if ((err = svn_cmdline_fflush(stdout)))
> + goto print_error;
> +
> print_error:
> /* If we had no errors before, print this error to stderr. Else, don't print
> anything. The user already knows there were some output errors,

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri May 5 18:51:52 2006

This is an archived mail posted to the Subversion Dev mailing list.