Re: svn commit: r19462 - in trunk: subversion/tests/cmdline subversion/tests/cmdline/svntest tools/test-scripts/svntest

On 4/27/06, Michael Haggerty <mhagger@alum.mit.edu> wrote:

> Therefore, I suggest the attached patch to be applied on top of yours.
>
> [[[
> Alter the XFail decorator to be immutable again.
>
> * subversion/tests/cmdline/svntest/testcase.py (XFail.__init__): Rename
> cond parameter to cond_func. Initialize cond_func to lambda:1 instead
> of None. Comment its deferred behavior here instead of in
> convert_result().
>
> (XFail.convert_result): Only reverse the result value if cond_func
> returns true. Don't overwrite self._result_text. Omit "if
> self.cond_func is None" test, as it is unnecessary now.
>
> (XFail.run_text): If self.cond_func returns true, then output run_text
> appropriate for a test that is expected to fail.
> ]]]

Looks perfectly reasonable to me. Feel free to apply, or if you
prefer just let me know and I'll check it in.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 28 00:58:32 2006